Upgrading to slf4j2 #1094
Merged
Upgrading to slf4j2 #1094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbittrich
approved these changes
May 22, 2024
Member
sbittrich
left a comment
sbittrich
left a comment
There was a problem hiding this comment.
LGTM, thanks.
Because it's nearby in the code: Do we have a plan for the MMTF deprecation? The codec is still useful once mmtf.rcsb.org stops serving data but could also get rid of it.
Contributor
Author
Yes the codec is still useful, so in principle it is a good idea to keep for a while longer. I would not want it to stay too long though, because there's not much maintenance on the mmtf codec java libs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As subject says