Skip to content

Conversation

@hilbertglm
Copy link
Contributor

I was going through the tutorial and was displaying a jmol panel. When I selected Show SCOP Domains for the color on the selection, I received a FileNotFoundException. A review of the Berkeley site shows that they changed from http to https for the scheme. They also appear to have changed the path portion of the URL in version 2 from 'scop' to 'scope.'

All of the unit tests worked before and after this change. I tried to create a unit test to show the failure, fix it, and run the unit test to show that it was fixed, but I couldn't quite follow the path to get to the ScopInstallation code from the Swing application.

To recreate my original error, the following code can be used (derived from the tutorial).

         Structure structure = StructureIO.getStructure("4FRW");
         System.out.println(StructureTools.getNrAtoms(structure));
         StructureAlignmentJmol jmolPanel = new StructureAlignmentJmol();

         jmolPanel.setStructure(structure);

         // send some commands to Jmol
         jmolPanel.evalString("select * ; color chain;");
         jmolPanel.evalString("select *; spacefill off; wireframe off; cartoon on;  ");
         jmolPanel.evalString("select ligands; cartoon off; wireframe 0.3; spacefill 0.5; color cpk;");

…of the URL path to reflect a change in the v2 naming.
Copy link
Contributor

@josemduarte josemduarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this! One comment in the review

SCOP_DOWNLOAD_ALTERNATE,
"dir.cla.scop.%s.txt","dir.des.scop.%s.txt",
"dir.hie.scop.%s.txt","dir.com.scop.%s.txt");
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 2 blocks in the if/else look identical. What was the intention of this change?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One is scope while the other is scop.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! sorry I missed that.

@josemduarte josemduarte merged commit 79f2062 into biojava:master Jan 25, 2024
@hilbertglm hilbertglm deleted the 20240108-scop branch January 26, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants