Skip to content

Fix local align score vector #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josemduarte merged 3 commits into from
Sep 30, 2022
Merged

Fix local align score vector #1036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bff5de7
Fix pointers[y] is null error
Jul 26, 2022
8a64963
Fix pointers[y] is null error
Jul 26, 2022
2781293
Test local, linear scheme alignment
Jul 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion biojava-alignment/src/main/java/org/biojava/nbio/alignment/routines/AlignerHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,7 +581,7 @@ public static Last[][] setScoreVector(int x, int xb, int yb, int ye, int gep, in
if (x == xb) {
pointers = new Last[ye + 1][1];
} else {
pointers = new Last[ye + 1][];
pointers = new Last[ye + 1][1];
pointers[0] = new Last[1];
for (int y = 1; y < scores[x].length; y++) {
pointers[y][0] = setScorePoint(x, y, gep, subs[y], scores);
Expand Down
12 changes: 12 additions & 0 deletions biojava-alignment/src/test/java/org/biojava/nbio/alignment/TestDNAAlignment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,4 +165,16 @@ public void testLinearAlignment() throws CompoundNotFoundException {
PairwiseSequenceAligner<DNASequence, NucleotideCompound> aligner = Alignments.getPairwiseAligner(query, target, PairwiseSequenceAlignerType.GLOBAL, gapP, matrix);
Assert.assertEquals(String.format("GTAAAA-G----------%nG-AAAACGTTTTTTTTTT%n"), aligner.getPair().toString());;
}
/**
* @author aegugup
*/
@Test
public void testLinearAlignmentLocal() throws CompoundNotFoundException {
DNASequence query = new DNASequence("TGTTACGG", DNACompoundSet.getDNACompoundSet());
DNASequence target = new DNASequence("GGTTGACTA", DNACompoundSet.getDNACompoundSet());
SubstitutionMatrix<NucleotideCompound> matrix = SubstitutionMatrixHelper.getNuc4_4();
SimpleGapPenalty gapP = new SimpleGapPenalty((short)0, (short)8);
PairwiseSequenceAligner<DNASequence, NucleotideCompound> aligner = Alignments.getPairwiseAligner(query, target, PairwiseSequenceAlignerType.LOCAL, gapP, matrix);
Assert.assertEquals(String.format("GTT-AC%nGTTGAC%n"), aligner.getPair().toString());;
}
}