Parsing resolution values in PDB (REMARK 2 and REMARK 3 [new format]) and mmCif #1001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently it affects only cryo-EM entries.
aalhossary
changed the title
Member
Author
|
I parsed the mmCif data from |
sbittrich
approved these changes
Dec 6, 2021
Member
sbittrich
left a comment
sbittrich
left a comment
There was a problem hiding this comment.
Thanks for the changes, LGTM.
1 small remark below.
biojava-structure/src/main/java/org/biojava/nbio/structure/io/cif/CifStructureConsumerImpl.java
Outdated
Show resolved
Hide resolved
the safer condition covers both UNKNOWN and NOT_PRESENT values
Member
Author
|
I fixed that. However, there is a new question in #1000 that needs answer before we close that issue and this PR. |
Member
Author
|
Is it fine now? Shall I merge? |
josemduarte
approved these changes
Dec 8, 2021
Contributor
josemduarte
left a comment
josemduarte
left a comment
There was a problem hiding this comment.
Just one more minor comment. After that it's ok to merge.
biojava-structure/src/main/java/org/biojava/nbio/structure/PDBHeader.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently it affects only cryo-EM entries.
Partially Fixes #1000
It fixes the PDBFileParser.
Before fixing the mmCifParser we need first to check whether the files should be remediated or not.