Better fix for null subunits as advised by @lafita

josemduarte · josemduarte · commit 96c6816366bb · 2017-10-10T09:00:02.000-07:00
diff --git a/biojava-structure/src/main/java/org/biojava/nbio/structure/symmetry/core/QuatSymmetryResults.java b/biojava-structure/src/main/java/org/biojava/nbio/structure/symmetry/core/QuatSymmetryResults.java
@@ -98,6 +98,11 @@ public QuatSymmetryResults(List<SubunitCluster> clusters,
 		this.clusters = clusters;
 		this.stoichiometry = SubunitClusterUtils
 				.getStoichiometryString(clusters);
+		
+		subunits = new ArrayList<Subunit>();
+		for (SubunitCluster c : clusters) {
+			subunits.addAll(c.getSubunits());
+		}
 
 		this.helixLayers = helixLayers;
 		this.method = method;
@@ -117,11 +122,8 @@ public List<SubunitCluster> getSubunitClusters() {
 	 *
 	 * @return an unmodifiable view of the List
 	 */
-	public List<Subunit> getSubunits() {
-		if (subunits != null)
-			return Collections.unmodifiableList(subunits);
-		else
-			return Collections.unmodifiableList(new ArrayList<>());
+	public List<Subunit> getSubunits() {		
+		return Collections.unmodifiableList(subunits);		
 	}
 	
 	/**
