bcif/models URL is a constant

sbittrich · sbittrich · commit 63d2ee7d2e25 · 2021-01-26T12:23:10.000-08:00
diff --git a/biojava-structure/src/main/java/org/biojava/nbio/structure/io/LocalPDBDirectory.java b/biojava-structure/src/main/java/org/biojava/nbio/structure/io/LocalPDBDirectory.java
@@ -63,6 +63,11 @@ public abstract class LocalPDBDirectory implements StructureIOFile {
 	public static final String DEFAULT_PDB_FILE_SERVER = "http://ftp.wwpdb.org";
 	public static final String PDB_FILE_SERVER_PROPERTY = "PDB.FILE.SERVER";
 
+	/**
+	 * The default server to retrieve BinaryCIF files.
+	 */
+	public static final String DEFAULT_BCIF_FILE_SERVER = "https://models.rcsb.org/";
+
 	/**
 	 * Behaviors for when an obsolete structure is requested.
 	 * @author Spencer Bliven
@@ -521,7 +526,8 @@ private File downloadStructure(String pdbId, String pathOnServer, boolean obsole
 		if (filename.endsWith(".mmtf.gz")){
 			ftp = CodecUtils.getMmtfEntryUrl(pdbId, true, false);
 		} else if (filename.endsWith(".bcif") || filename.endsWith(".bcif.gz")) {
-			ftp = "https://models.rcsb.org/" + filename;
+			// TODO this should be configurable
+			ftp = DEFAULT_BCIF_FILE_SERVER + filename;
 		} else {
 			ftp = String.format("%s%s/%s/%s",
 			serverName, pathOnServer, pdbId.substring(1,3).toLowerCase(), getFilename(pdbId));
