Skip to content

Commit 0ff1823

Browse files
committed
Clarifying docs and some more cleanup
1 parent 7c7caa2 commit 0ff1823

3 files changed

Lines changed: 3 additions & 39 deletions

File tree

biojava-structure/src/main/java/org/biojava/nbio/structure/Atom.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,8 @@ public interface Atom extends Cloneable, PDBRecord {
163163

164164
/**
165165
* Get alternate Location.
166-
* @return a Character object representing the alt loc value
166+
* @return a Character object representing the alt loc value. Default altLoc ('.' in mmCIF files)
167+
* is represented by ' ' (space character, ascii 32).
167168
* @see #setAltLoc
168169
*/
169170
public Character getAltLoc();

biojava-structure/src/main/java/org/biojava/nbio/structure/AtomImpl.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -157,10 +157,6 @@ public void setZ(double z) {
157157
@Override
158158
public double getZ() { return coords.z; }
159159

160-
/**
161-
* Set alternate Location.
162-
* @see #getAltLoc
163-
*/
164160
@Override
165161
public void setAltLoc(Character c) {
166162
// after changing altLoc from Character to char, we do this to keep the interface the same as it used to be - JD 2016-01-27
@@ -170,11 +166,6 @@ public void setAltLoc(Character c) {
170166
altLoc = c ;
171167
}
172168

173-
/**
174-
* Get alternate Location.
175-
* @return a Character object representing the alt loc value
176-
* @see #setAltLoc
177-
*/
178169
@Override
179170
public Character getAltLoc() {
180171
// after changing altLoc from Character to char, we do this to keep the interface the same as it used to be - JD 2016-01-27

biojava-structure/src/main/java/org/biojava/nbio/structure/HetatomImpl.java

Lines changed: 1 addition & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -254,16 +254,13 @@ public boolean hasAtom(String fullName) {
254254
Atom a = atomNameLookup.get(fullName.trim());
255255
return a != null;
256256
} else {
257-
/** This is the performance penalty we pay for NOT using the atomnameLookup in PerformanceBehaviour.LESS_MEMORY_SLOWER_PERFORMANCE
258-
*/
257+
// This is the performance penalty we pay for NOT using the atomnameLookup in PerformanceBehaviour.LESS_MEMORY_SLOWER_PERFORMANCE
259258
for (Atom a : atoms) {
260259
if (a.getName().equals(fullName)) {
261260
return true;
262261
}
263262
}
264263
return false;
265-
266-
267264
}
268265

269266
}
@@ -375,42 +372,21 @@ public void setProperties(Map<String,Object> props) {
375372
properties = props ;
376373
}
377374

378-
/** return properties.
379-
*
380-
* @return a HashMap object representing the properties value
381-
* @see #setProperties
382-
*/
383375
@Override
384376
public Map<String, Object> getProperties() {
385377
return properties ;
386378
}
387379

388-
/** set a single property .
389-
*
390-
* @see #getProperties
391-
* @see #getProperty
392-
*/
393380
@Override
394381
public void setProperty(String key, Object value){
395382
properties.put(key,value);
396383
}
397384

398-
/** get a single property .
399-
* @param key a String
400-
* @return an Object
401-
* @see #setProperty
402-
* @see #setProperties
403-
*/
404385
@Override
405386
public Object getProperty(String key){
406387
return properties.get(key);
407388
}
408389

409-
410-
/** return an AtomIterator.
411-
*
412-
* @return an Iterator object
413-
*/
414390
@Override
415391
public Iterator<Atom> iterator() {
416392
return new AtomIterator(this);
@@ -615,10 +591,6 @@ public boolean isWater() {
615591
return GroupType.WATERNAMES.contains(pdb_name);
616592
}
617593

618-
/** attempts to reduce the memory imprint of this group by trimming
619-
* all internal Collection objects to the required size.
620-
*
621-
*/
622594
@Override
623595
public void trimToSize(){
624596

0 commit comments

Comments
 (0)