Improve VSCode default comment function behavior#47
Merged
liyao001 merged 1 commit intobioSyntax:masterfrom Mar 7, 2019
alanhoyle:master
Merged
Improve VSCode default comment function behavior#47liyao001 merged 1 commit intobioSyntax:masterfrom alanhoyle:master
liyao001 merged 1 commit intobioSyntax:masterfrom
alanhoyle:master
Conversation
Currently, any bioSyntax files within VSCode default to having the "Toggle Line Comment" function add a "//" at the beginning of the line, and the "Toggle Block Comment" encloses the selection in "/* ... */". This change disables block comments and changes the Toggle Line Comment to use "#" which is much more common in these types of files.
liyao001
approved these changes
Mar 7, 2019
Contributor
liyao001
left a comment
liyao001
left a comment
There was a problem hiding this comment.
Great! I'll update the VSCode plugin later today.
Contributor
Author
|
There might be a tiny bug here: While trailing commas are allowed in JavaScript, apparently, they're not supposed to be allowed in JSON objects. The patch works when I put it in place, but it might be better if the trailing comma was removed. |
Contributor
Author
|
It appears that the JSON interpreter in VSC handles trailing commas and comments just fine, so no need to worry unless they change the interpreter. . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, any bioSyntax files within VSCode default to having the "Toggle Line Comment" function add a "//" at the beginning of the line, and the "Toggle Block Comment" encloses the selection in "/* ... */".
This change disables block comments and changes the Toggle Line Comment to use "#" which is much more common in these types of files.