Skip to content

update: 修复accesstoken无效，导致循环调用的bug #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
luckalphie wants to merge 1 commit into from
Closed

update: 修复accesstoken无效，导致循环调用的bug #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions weixin-java-mp/src/main/java/me/chanjar/weixin/mp/api/WxMpService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,14 @@ public interface WxMpService {
*/
String getAccessToken(boolean forceRefresh) throws WxErrorException;


/**
* <pre>
* 强制accessToken过期
* </pre>
*/
void expireAccessToken();

/**
* 获得jsapi_ticket,不强制刷新jsapi_ticket
*
Expand Down
13 changes: 10 additions & 3 deletions weixin-java-mp/src/main/java/me/chanjar/weixin/mp/api/impl/WxMpServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ public String getAccessToken() throws WxErrorException {
@Override
public String getAccessToken(boolean forceRefresh) throws WxErrorException {
if (forceRefresh) {
this.configStorage.expireAccessToken();
expireAccessToken();
}
if (this.configStorage.isAccessTokenExpired()) {
synchronized (this.globalAccessTokenRefreshLock) {
Expand Down Expand Up @@ -134,6 +134,11 @@ public String getAccessToken(boolean forceRefresh) throws WxErrorException {
return this.configStorage.getAccessToken();
}

@Override
public void expireAccessToken(){
this.configStorage.expireAccessToken();
}

@Override
public String getJsapiTicket() throws WxErrorException {
return getJsapiTicket(false);
Expand Down Expand Up @@ -410,8 +415,10 @@ protected synchronized <T, E> T executeInternal(RequestExecutor<T, E> executor,
*/
if (error.getErrorCode() == 42001 || error.getErrorCode() == 40001) {
// 强制设置wxMpConfigStorage它的access token过期了，这样在下一次请求里就会刷新access token
this.configStorage.expireAccessToken();
return this.execute(executor, uri, data);
//this.configStorage.expireAccessToken();
//return this.execute(executor, uri, data);
//此方法可被重写
expireAccessToken();
Copy link
Copy Markdown
Owner

@binarywang binarywang Nov 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你这种做法虽然解决了你的死循环问题，但考虑不够全面，会导致token过期无法自动刷新的问题，造成用户请求无法直接得到结果，而必须再次重试

}
if (error.getErrorCode() != 0) {
this.log.error("\n[URL]: {}\n[PARAMS]: {}\n[RESPONSE]: {}", uri, data,
Expand Down