Repository navigation
查询订单支付状态返回的结果WxMpPayResult增加新字段 - #43
Merged
Merged
Conversation
aalx
commented
Sep 21, 2016
binarywang
reviewed
Sep 21, 2016
binarywang
left a comment
Owner
There was a problem hiding this comment.
感谢提交PR,顺便你把charjaster那边的PR关掉吧
| */ | ||
| private String cash_fee_type; | ||
| public String getReturn_code() { | ||
| return this.return_code; |
Owner
There was a problem hiding this comment.
感谢提交,你的编辑器有保存时自动格式化所有代码的功能吗?为什么有这么多无关的修改?建议去掉格式化所有代码行的设置,仅格式化你自己添加修改的代码即可
Author
There was a problem hiding this comment.
这个格式我啥也没干,好像只是合并了某个分支还是怎么的,有这么多无关的提交,刚才发PR的时候也发现了,另外刚开始学习对别人的项目PR,操作还不太熟悉,不规范的地方多指正
| /** | ||
| * 现金支付金额 cash_fee 是 Int 100 现金支付金额订单现金支付金额,详见支付金额 | ||
| */ | ||
| private String cash_fee; |
Owner
There was a problem hiding this comment.
字段命名不够规范,建议使用java标准的驼峰命名,不过之前的代码也还未规范化,如果有空的话可以帮忙规范下,没有时间的话就先暂时这样,以后抽时间再弄
Author
There was a problem hiding this comment.
关于命名的问题,我看过原来的项目,是为了好在微信端返回xml或json时序列化对象时直接使用工具,不用其它操作,我猜之前不规范也是基于这个考虑的吧
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.