Skip to content

修复 WxCpRedisConfigImpl.getWebhookKey() 无限递归调用 #3821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
binarywang merged 6 commits into from
Dec 24, 2025
Merged

修复 WxCpRedisConfigImpl.getWebhookKey() 无限递归调用 #3821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
41ea34a
Initial plan
Copilot Dec 24, 2025
44ff4bb
修复 WxCpRedisConfigImpl 中的无限递归调用问题并添加单元测试
Copilot Dec 24, 2025
32158d2
移除测试类中不必要的作者标注
Copilot Dec 24, 2025
8c07b16
Update weixin-java-cp/src/test/java/me/chanjar/weixin/cp/config/impl/…
binarywang Dec 24, 2025
ab9cc33
Update weixin-java-cp/src/test/java/me/chanjar/weixin/cp/config/impl/…
binarywang Dec 24, 2025
210d9e5
使用 Mockito mock JedisPool 避免测试时真实连接 Redis
Copilot Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion weixin-java-cp/src/main/java/me/chanjar/weixin/cp/config/impl/WxCpRedisConfigImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,7 @@ public boolean autoRefreshToken() {

@Override
public String getWebhookKey() {
return this.getWebhookKey();
return this.webhookKey;
}

@Override
Expand Down
48 changes: 48 additions & 0 deletions weixin-java-cp/src/test/java/me/chanjar/weixin/cp/config/impl/WxCpRedisConfigImplTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
package me.chanjar.weixin.cp.config.impl;

import org.mockito.Mockito;
import org.testng.Assert;
import org.testng.annotations.Test;
import redis.clients.jedis.JedisPool;

/**
* WxCpRedisConfigImpl 测试类
*/
public class WxCpRedisConfigImplTest {

/**
* 测试 getWebhookKey 方法不会导致无限递归
* 这个测试验证了 #issue 中提到的无限递归问题已被修复
*/
@Test
public void testGetWebhookKeyNoInfiniteRecursion() {
// 使用 Mockito 创建 mock JedisPool，避免真实连接
JedisPool jedisPool = Mockito.mock(JedisPool.class);

WxCpRedisConfigImpl config = new WxCpRedisConfigImpl(jedisPool);

// 测试1: webhookKey 为 null 时应该返回 null，而不是抛出 StackOverflowError
String webhookKey = config.getWebhookKey();
Assert.assertNull(webhookKey, "未设置 webhookKey 时应返回 null");

// 测试2: 通过反射设置 webhookKey，然后验证能够正确获取
// 注意：由于 WxCpRedisConfigImpl 没有提供 setWebhookKey 方法，
// 我们通过反射来设置这个字段以测试 getter 的正确性
try {
java.lang.reflect.Field field = WxCpRedisConfigImpl.class.getDeclaredField("webhookKey");
boolean originalAccessible = field.isAccessible();
field.setAccessible(true);
try {
String testWebhookKey = "test-webhook-key-123";
field.set(config, testWebhookKey);

String retrievedKey = config.getWebhookKey();
Assert.assertEquals(retrievedKey, testWebhookKey, "应该返回设置的 webhookKey 值");
} finally {
field.setAccessible(originalAccessible);
}
} catch (NoSuchFieldException | IllegalAccessException e) {
Assert.fail("反射设置 webhookKey 失败: " + e.getMessage());
}
}
}