Merged
Conversation
Owner
|
说下我发现的几个问题吧,首先你的缩进格式跟我们要求的不太一致,其次新增的方法其实大部分跟你标为过时的方法差别不大,其实大可以在原方法上直接改,对客户端影响很小。 |
Owner
|
如果可以的话其他几个类似用到证书文件的接口也可以做类似的重构,保证接口代码的一致。 |
Author
|
嗯嗯,我使用的是eclipse,在修改前我特意的去看了说明,是2空格代替tab,我想可能是对eclipse配置不正确。对于修改原方法,我是怕影响了部分人升级版本导致项目一堆的报错。 |
Owner
|
首页说明提到了使用editorconfig即可,就不需要配置eclipse了 |
Owner
|
升级报错没关系,反正现在大版本不会发布那么频繁,而且一般用到对应方法的也应该很容易看出问题,自己就随手修复了。 |
Owner
|
还有个问题就是你没有做单元测试,如果是修改原方法的话,只用修改原有的单元测试就好了 |
Owner
|
不过我还是先把代码合并过来,先帮你把格式什么的弄好,你以后注意下就好了 |
Author
|
好的,麻烦你了,第一次参与开源项目,谢谢提醒,我以后注意。 |
binarywang
added a commit
that referenced
this pull request
Dec 26, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
启用新的简单红包接口,在这之前请初始化WxMpConfigStorage.SslContext