Skip to content

Solari fixes #21747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Solari fixes #21747

wants to merge 1 commit into from

Conversation

@JMS55
Copy link
Contributor

@JMS55 JMS55 commented Nov 5, 2025

  • Fix overflow/nans in specular BRDF by clamping (not sure if there's a better way to fix this...)
  • Reduce jacobian rejection threshold to prevent light leaks (more aggressive cutoff now)
  • Lower world cache RIS samples fro 32 to 8 to match ReSTIR DI

@JMS55 JMS55 added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen C-Refinement Improves output quality, without fixing a clear bug or adding new functionality. labels Nov 5, 2025
@JMS55 JMS55 requested review from SparkyPotato and atlv24 November 5, 2025 02:55
@alice-i-cecile alice-i-cecile added the S-Needs-Review Needs reviewer attention (from anyone!) to move forward label Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atlv24 atlv24 Awaiting requested review from atlv24

@SparkyPotato SparkyPotato Awaiting requested review from SparkyPotato

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior C-Refinement Improves output quality, without fixing a clear bug or adding new functionality. S-Needs-Review Needs reviewer attention (from anyone!) to move forward

Projects

Rendering
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JMS55 @alice-i-cecile