documented run_system_cached issue#21617 #21707
Open
+24
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
kristoff3r
reviewed
Nov 2, 2025
Comment on lines
522
to
530
| /// Runs a cached system, registering it if necessary. | ||
| /// | ||
| /// # Type Inference Note | ||
| /// If the system returns `()`, you may need to explicitly constrain the output | ||
| /// type for error handling: | ||
| /// | ||
| /// ```rust | ||
| /// () = world.run_system_cached(my_system)?; | ||
| /// ``` |
There was a problem hiding this comment.
This has a duplicate header, and the type inference example should use the run_system_cached_with function
There was a problem hiding this comment.
Fixed! Header removed and example updated. Thanks for the note.
alice-i-cecile
added
C-Docs
alice-i-cecile
added
S-Needs-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
World::run_system_cached(_with)needs type hints for error handling #21617 by adding documentation to both run_system_cached functionsSolution