You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#21601 introduced helpers to dynamically access relationship values
The RelationshipAccessor can be hard to use manually as it requires manipulating pointers; we can provide helper functions in UnsafeEntityCell and friends to access those.
cBournhonesque
added
A-ECS
Entities, components, systems, and events
C-Usability
A targeted quality-of-life change that makes Bevy easier to use
D-Modest
A "normal" level of difficulty; suitable for simple features or challenging fixes
S-Needs-Review
Needs reviewer attention (from anyone!) to move forward
labels
Oct 23, 2025
Is there a reason why these functions return Box<dyn Iterator> instead of impl Iterator?
Also I am curious how it would error if the '_ are removed, given how use<'a> became a thing recently.
Is there a reason why these functions return Box<dyn Iterator> instead of impl Iterator? Also I am curious how it would error if the '_ are removed, given how use<'a> became a thing recently.
You're right, impl Iterator is much better! will change
Very much think this should exist and the implementation looks good but:
Naming needs work.
Needs tests.
CI needs to pass <3 I've previously just copy-pasted output from CI >.>
For naming, what do you suggest? I was thinking of get_relationship_target and get_relationship_sources to reuse some of the naming conventions introduced by the Relationship trait.
Yes, will add
@mockersf do you have idea on how i can make the compile-fail pass? i tried running with BLESSED once, but it didn't seem to help
A-ECSEntities, components, systems, and eventsC-UsabilityA targeted quality-of-life change that makes Bevy easier to useD-ModestA "normal" level of difficulty; suitable for simple features or challenging fixesS-Needs-HelpThe author needs help finishing this PR.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cBournhonesque
added
A-ECS
alice-i-cecile
added
S-Needs-Help
Objective
#21601 introduced helpers to dynamically access relationship values
The
RelationshipAccessorcan be hard to use manually as it requires manipulating pointers; we can provide helper functions inUnsafeEntityCelland friends to access those.