[0.x] DoctrineDriver: Fix "LIMIT 1FOR UPDATE" #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e query working again
MatthiasKuehneEllerhold
changed the title
Member
|
@sagikazarmark should we still merge this PR and release a new 0.x version? We are working towards 1.0 and this fix is already present in newer versions so a "upgrade" from 0.x to 1.0-alpha would fix this issue |
Contributor
|
I have no problem with merging it and tagging as a 0.x patch release. Until 1.0 0.x is the "stable" release branch. |
Contributor
|
@acrobat Do you want to merge it or should I? |
Member
|
Ok thanks for the feedback! I will merge and release! |
Member
|
Thanks @MatthiasKuehneEllerhold! |
Member
|
@MatthiasKuehneEllerhold a new version was tagged, see 0.12.4 |
Author
|
Happy to help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using bernardphp with the doctrine driver produces this invalid SELECT statement:
As you can see there is a space missing between "LIMIT 1" and "FOR UPDATE".
This error exists in 0.12.3 (latest stable) and the 0.x branch. It is fixed in the master though.
This error is thrown and silently ignored in the driver so it never makes it to the consumer. This makes it very hard to notice.