Fix CI: Handle grep exit code when filtering settings.rst

benoitc · benoitc · commit 3e0c1c585784 · 2025-10-05T19:28:15.000+02:00
When settings.rst is the only changed file, grep -v returns exit code 1
because there are no matches after filtering. Adding '|| true' ensures
the pipeline continues and correctly identifies no relevant changes.
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -43,7 +43,9 @@ jobs:
           # this will update docs/source/settings.rst - but will not create html output
           (cd docs && sphinx-build -b "dummy" -d _build/doctrees source "_build/dummy")
           # Check for uncommitted changes, excluding settings.rst which is auto-generated
-          if unclean=$(git status --untracked-files=no --porcelain | grep -v "docs/source/settings.rst") && [ -z "$unclean" ]; then
+          # Use grep -v to filter out settings.rst; if grep returns 1 (no matches), that's OK
+          unclean=$(git status --untracked-files=no --porcelain | grep -v "docs/source/settings.rst" || true)
+          if [ -z "$unclean" ]; then
             echo "no uncommitted changes in working tree (as it should be)"
           else
             echo "did you forget to run `make -C docs html`?"
