Implement P3168R1: Give std::optional Range Support#9
Merged
neatudarius merged 21 commits intomainfrom Jun 19, 2024
Merged
Conversation
neatudarius
force-pushed
the
neatudarius/P3168R1
branch
2 times, most recently
from
17ea2a2 to
4cb36c4
Compare
neatudarius
changed the title
brevzin
reviewed
Jun 13, 2024
| using value_type = T; | ||
| // Since P3168R1: Give std::optional Range Support. | ||
| using iterator = T*; // see [optional.iterators] | ||
| using const_iterator = const T*; // see [optional.iterators] |
There was a problem hiding this comment.
It would be better to not use pointers.
Member
Author
There was a problem hiding this comment.
@brevzin , I agree with you and I have a WIP patch for an iterator implementation. I would like to put this work in a new PR, if that's OK with you.
neatudarius
force-pushed
the
neatudarius/P3168R1
branch
from
4cb36c4 to
7a30db7
Compare
neatudarius
force-pushed
the
neatudarius/P3168R1
branch
2 times, most recently
from
cd60fb9 to
7a30db7
Compare
neatudarius
force-pushed
the
neatudarius/P3168R1
branch
from
1b8686c to
cebf476
Compare
neatudarius
force-pushed
the
neatudarius/P3168R1
branch
from
fc5733a to
909f0bc
Compare
neatudarius
force-pushed
the
neatudarius/P3168R1
branch
from
890ff1b to
923fde0
Compare
neatudarius
changed the title
…ll platforms on local setups
Member
Getting 24.10 is unexpected - what we want is 24.04, which also isn't or wasn't ubuntu-latest yet. |
JeffGarland
reviewed
Jun 19, 2024
Member
Author
OK. We can address it in issue - #1 |
This was referenced Jun 19, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement P3168R1: Give std::optional Range Support - issue #14 .
Note:
__cpp_lib_format_rangesavailable only onclang(check comments fromoptional.hpp.