R7 and 8 of the paper and fixes to optional after wording and LEWG reviews. #70
Merged
steve-downey merged 127 commits intobemanproject:mainfrom Nov 4, 2024
Merged
R7 and 8 of the paper and fixes to optional after wording and LEWG reviews. #70steve-downey merged 127 commits intobemanproject:mainfrom
steve-downey merged 127 commits intobemanproject:mainfrom
Conversation
Header is in sync with synopsis.
Make class declaration the synopsis version.
Move the assignment operators out of class synopsis declaration.
Define swap out of body
Definitions of begin and end moved out of line.
Move definitions out of the class declaration.
and_then etc out of line
Move reset out of the body.
Move the free functions out of the namespace. Make sure no declarations are unintended from a slightly different definition.
optional_map_impl and monostate are dead.
Standardese lives in std and avoids naming the namespace, except for move and forward.
No extra definitions snuck in, all back now inside the namespace so are not noise.
Make change tracking back to std a little easier.
Apply all the changes to optional to the wording section of P2988.
Replace by expos or implementation defined.
optional<T&&>
The type of the u parameter must be convertible to a T, and T must be copy constructible.
A few additional std:: names. Also remove the anon namespace. Doesn't protect much as the std:: names are still available if someone uses namespace optional26.
Fix missing tex escapes in code blocks
Removed a stray detail:: that refereces a polyfill std:: trait.
Git marks all as renames, so history is connected.
Beman.Optional26 becomes beman.optional26, and Optional26 becomes optional26.
Don't leak std:: names into the optional26 namespace.
GCC is flase positive wanring on this in Anan mode.
Fix conflicts between main and the r8 branch
Lint
Remove the capability to make the misleading call of make_optional with an explicit reference template parameter. This is the same technique, for the same reasons, as is used for variant visit.
Remove make_optional<T&> from wording.
Further updates for make_optional explanation.
Merging the current main into a branch for merge into PR branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wording review for paper, and fixes to make sure the constraints/mandates enforce the non-dangling design and other improvements in the API as suggested in reviews.