any suggestion what error msg I should give for this case?

static_assert((!std::is_same_v<T, std::remove_cv_t<in_place_t>>) && (!std::is_same_v<std::remove_cv_t<T>, nullopt_t>))

any suggestion what error msg I should give for this case?

static_assert((!std::is_same_v<T, std::remove_cv_t<in_place_t>>) && (!std::is_same_v<std::remove_cv_t<T>, nullopt_t>))

Something like, "T must not be in_place_t or nullopt_t" ?

any suggestion what error msg I should give for this case?
static_assert((!std::is_same_v<T, std::remove_cv_t<in_place_t>>) && (!std::is_same_v<std::remove_cv_t<T>, nullopt_t>))

Something like, "T must not be in_place_t or nullopt_t" ?

Thanks! I see there is a remove_cv_t, I was thinking I should say something like "T without cv qualification must not be nullopt_t"

I tried to add a line

beman::optional26::optional<beman::optional26::nullopt_t> op;

to file concept_checks.cpp

Here is the error log before the message is added

optional26/include/beman/optional26/optional.hpp:290:5: error: static assertion failed
      due to requirement '!std::is_same_v<beman::optional26::nullopt_t, beman::optional26::nullopt_t>'
    static_assert(
    ^
/Users/nguyennhat/Desktop/optional26/examples/concept_checks.cpp:97:63: note: in instantiation of template class
      'beman::optional26::optional<beman::optional26::nullopt_t>' requested here
    beman::optional26::optional<beman::optional26::nullopt_t> op;

Here is the error log after the message is added

optional26/include/beman/optional26/optional.hpp:290:5: error: static assertion failed
      due to requirement '!std::is_same_v<beman::optional26::nullopt_t, beman::optional26::nullopt_t>': T must not be in_place_t or
      nullopt_t
    static_assert(
    ^
/Users/nguyennhat/Desktop/optional26/examples/concept_checks.cpp:97:63: note: in instantiation of template class
      'beman::optional26::optional<beman::optional26::nullopt_t>' requested here
    beman::optional26::optional<beman::optional26::nullopt_t> op;

@neatudarius @steve-downey
I dont have permission to merge, can you run the CI again and if things look good, can you merge for me? Thanks

Sure, not a problem.

@changkhothuychung , please fix precommit before merge. Otherwise LGTM

@changkhothuychung , one more try? I will check repo settings to automatically run CI for any PR without approval.

@changkhothuychung , one more try? I will check repo settings to automatically run CI for any PR without approval.

It should always run CI when you push.