Renamed files, directories, and targets to match beman standard #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[LIBRARY_NAMES] [CMAKE.PROJECT_NAME] [CMAKE.LIBRARY_NAME] [CMAKE.TARGET_NAMES] [DIRECTORY.INTERFACE_HEADERS]
neatudarius
approved these changes
Sep 17, 2024
Member
There was a problem hiding this comment.
LGTM 👍
Please check compiler explorer links included in root readme. After you merge this PR, an overnight deploy will be done automatically with compiler explorer, but we need to update our samples.
ps If you need to force deploy please ping an owner in compiler explorer - check link issue with #21
Member
|
It's slightly annoying that many of the files are deleted and added instead
of being renamed, because they are short.
…On Tue, Sep 17, 2024, 06:10 Darius Neațu ***@***.***> wrote:
***@***.**** approved this pull request.
------------------------------
On CMakeLists.txt
<#60 (comment)>
:
LGTM 👍
Please check compiler explorer links included in root readme. After you
merge this PR, an overnight deploy will be done automatically with compiler
explorer, but we need to update our samples.
—
Reply to this email directly, view it on GitHub
<#60 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVNZ5Q2F4XN2H5NJ256J6TZW752TAVCNFSM6AAAAABOKRMOY6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGMBZGI4DKNJZG4>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Member
|
but I don't really feel strongly, just trying to see if I could make github cooperate better. |
Member
Author
|
I suppose to make #61 do what you want it to do, you'll have to not "squash and merge" the final result. |
Member
|
Since "squash merge" is another way of spelling "merge conflict", yes. It
disconnects the history more generally and prevents merging on branches.
…On Tue, Sep 17, 2024, 11:48 David Sankel ***@***.***> wrote:
I suppose to make #61
<#61> do what you want it
to do, you'll have to not "squash and merge" the final result.
—
Reply to this email directly, view it on GitHub
<#60 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVNZ5UNURWXULOZWCQ7LHDZXBFLHAVCNFSM6AAAAABOKRMOY6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJWGMYDSMRSGI>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Member
|
Is this PR still applicable? |
Member
|
I think it's now obsolete. Landed a version that did the rename and edit in
two steps to preserve the rename in history.
…On Tue, Sep 24, 2024, 08:43 Darius Neațu ***@***.***> wrote:
Is this PR still applicable?
—
Reply to this email directly, view it on GitHub
<#60 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVNZ5XIN6AKEGRJQPRJ4O3ZYFM6VAVCNFSM6AAAAABOKRMOY6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZRGE3DMMJZGM>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Member
Author
|
Closing as obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[LIBRARY_NAMES]
[CMAKE.PROJECT_NAME]
[CMAKE.LIBRARY_NAME]
[CMAKE.TARGET_NAMES]
[DIRECTORY.INTERFACE_HEADERS]