Avoid reopening namespace std#54
Merged
steve-downey merged 1 commit intobemanproject:mainfrom Aug 29, 2024
Merged
Conversation
frederick-vs-ja
requested review from
camio,
neatudarius and
steve-downey
as code owners
neatudarius
approved these changes
Aug 27, 2024
Member
neatudarius
left a comment
neatudarius
left a comment
There was a problem hiding this comment.
LGTM 👍
Indeed, it does not compile with MSVC. I isolated a minimal code here https://godbolt.org/z/zvq5Mf4eW.
CC: @steve-downey
Member
|
It looks good to me, too. |
Member
|
@frederick-vs-ja , please proceed with the PR merge. I would also like to check if you have permissions this way. |
Contributor
Author
I don't have write permission currently. Would you like to merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the suggestion in Don’t reopen
namespace std.The change also works around a bug of MSVC (reduced and reported on DevCom).
Godbolt links:
Drive-by: Remove emoji
🔗from the synopsis comments, which seems to be copied from https://eel.is/c++draft/optional.syn.