Skip to content

update LWG status and add a godbolt link to docs#24

Merged
JeffGarland merged 1 commit intobemanproject:mainfrom
JeffGarland:main
Jun 27, 2024
Merged

update LWG status and add a godbolt link to docs#24
JeffGarland merged 1 commit intobemanproject:mainfrom
JeffGarland:main

Conversation

@JeffGarland
Copy link
Member

Updates before the presentation tonight

Copy link
Member

@neatudarius neatudarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 , but I propose to move this diff in my PR (#23) or to update the included link in this PR:

@JeffGarland
Copy link
Member Author

LGTM 👍 , but I propose to move this diff in my PR (#23) or to update the included link in this PR:

* your link https://godbolt.org/z/b5ThEqqhf

* my links have a specific format (license, multiple compilers/C++ standards): https://godbolt.org/z/f8dWaxsGo (btw, this link is already included for the same example in `examples/README.md` in my branch, not it's also pushed into the root README)

I'm aware of the link you put in the other PR -- it's just a little overwhelming to see all the sub-windows popping up. This was more curated for a presentation audience to 'see a small code snippet' and discuss things like the include path and namespaces.

How about I merge and you can sort out the final set of links in yours?

@neatudarius
Copy link
Member

LGTM 👍 , but I propose to move this diff in my PR (#23) or to update the included link in this PR:

* your link https://godbolt.org/z/b5ThEqqhf

* my links have a specific format (license, multiple compilers/C++ standards): https://godbolt.org/z/f8dWaxsGo (btw, this link is already included for the same example in `examples/README.md` in my branch, not it's also pushed into the root README)

I'm aware of the link you put in the other PR -- it's just a little overwhelming to see all the sub-windows popping up. This was more curated for a presentation audience to 'see a small code snippet' and discuss things like the include path and namespaces.

How about I merge and you can sort out the final set of links in yours?

Sure. Ship it!

Copy link
Member

@steve-downey steve-downey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JeffGarland JeffGarland merged commit 2a60bc7 into bemanproject:main Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants