Closed
Conversation
Member
|
Seems like clang 17 isn't quite up to the task, do we really care? Seems likely that the ongoing 'what compilers' to support discussion will continue to heat up as we do real work. |
Member
Author
|
It is bothering me because it appears to work on my machine. But I think
that is because I happen to have the libc++ from 19 installed, and that
avoids the particular error.
Libc++ from 17 did not have join, so sone tests fail.
It may not be worth going back to clang-17, though, I agree.
…On Tue, Jun 18, 2024, 23:00 Jeff Garland ***@***.***> wrote:
Seems like clang 17 isn't quite up to the task, do we really care? Seems
likely that the ongoing 'what compilers' to support discussion will
continue to heat up as we do real work.
—
Reply to this email directly, view it on GitHub
<#15 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVNZ5T67KPMSOM4FFY2NTTZIDX37AVCNFSM6AAAAABJQYM5RSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZXGQ2TENRRGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Member
|
@steve-downey , I merged #9 . You can update your branch to see why the clang-19 job failed on that particular job/code. |
libc++ hadn't implemented join as of 17, use libstdc++ instead.
A different set of problems with googletest HEAD arises.
Optional26/src/Beman/optional/optional.t.cpp:827:32:
error: no member named 'join' in namespace 'std::ranges::views'
std::ranges::views::join;
~~~~~~~~~~~~~~~~~~~~^
Undo the verbose script run and remove the commented out force install of libc++ version.
Member
Author
|
I'll put up a cleaner PR now that this is working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.