Conversation
C++20 compilers more restricted in their constexpr capabilities. Use fewer of the gtest macros, which are not consteval capable in C++20 with GCC.
Run cmake and clang formatting passes.
Pull Request Test Coverage Report for Build 15959666185Details
💛 - Coveralls |
neatudarius
approved these changes
Jun 30, 2025
JeffGarland
reviewed
Jul 1, 2025
| include_guard(GLOBAL) | ||
|
|
||
| set(CMAKE_CXX_STANDARD 23) | ||
| set(CMAKE_CXX_STANDARD 20) |
Member
There was a problem hiding this comment.
I mean this works around the compile bug for tests, but my bug report would still be a problem?
sorry had to refresh my memory -- this directly tests my issue, thanks
JeffGarland
reviewed
Jul 1, 2025
| std::abort(); | ||
| } else { | ||
| gtest_expect_eq(std::forward<U>(val1), std::forward<V>(val2)); | ||
| } |
Member
|
LGTM - ship it. |
JeffGarland
approved these changes
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make unit testing constexpr compatible in C++20.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=120868 was in the way, at least partially.
Fixes #123