Conversation
Make 4.4, which comes with Ubuntu 25.04, changes how recursive macros are processed. Fix to make macros not as recursive.
Set just the CMAKE_CXX_STANDARD, not the -std flag directly.
__cpp_lib_format_ranges is defined in version. Checking without including causes strange errors when it becomes defined later.
GCC 15.1.1 and higher have the feature. Check that it works for the GCC version, and check if the feature is indicated available by the macro.
Pull Request Test Coverage Report for Build 15365633436Details
💛 - Coveralls |
neatudarius
approved these changes
May 26, 2025
Member
Author
|
Accidentally deleted the branch in my fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC 15 release branch and GCC 16 have support for format_kind, revealing that the support in beman.optional has always been broken.