fix: use nullish coalescing for job data and options defaults - #1031
Open
tsushanth wants to merge 1 commit into
Open
fix: use nullish coalescing for job data and options defaults#1031tsushanth wants to merge 1 commit into
tsushanth wants to merge 1 commit into
Conversation
Replace || with ?? when initializing data, options, timestamp, and stacktraces so that falsy-but-valid values (false, 0, empty string) are not silently replaced with the default. A job created with numeric or boolean data was losing its payload.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Jobconstructor uses||to supply defaults fordata,options,options.timestamp, andoptions.stacktraces. This silently replaces any falsy-but-valid value with the default:A queue consumer that stores boolean flags, numeric codes, or empty strings as job data loses the payload silently.
Fix
Replace
||with??so onlynullandundefinedfall through to the default:Reproduction