Skip to content
This repository was archived by the owner on Aug 7, 2024. It is now read-only.

migrate api.PostDirectMessage to new twitter api#579

Merged
bear merged 1 commit intobear:masterfrom
jmingtan:master
Sep 29, 2018
Merged

migrate api.PostDirectMessage to new twitter api#579
bear merged 1 commit intobear:masterfrom
jmingtan:master

Conversation

@jmingtan
Copy link
Contributor

@jmingtan jmingtan commented Aug 15, 2018

This PR migrates the existing PostDirectMessage method to use the new Twitter API documented at https://developer.twitter.com/en/docs/direct-messages/sending-and-receiving/api-reference/new-event.

This is a breaking change as both the input format and the response format are quite different; for example screen_name is no longer supported as a parameter, and the return result also no longer contains hydrated recipient and sender objects.


This change is Reviewable

@ganmedia
Copy link

Any news about this?

Copy link
Owner

@bear bear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Owner

@bear bear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@bear bear merged commit 4850fbc into bear:master Sep 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants