This repository was archived by the owner on Aug 7, 2024. It is now read-only.
Updates Media object with new methods, adds id param, adds tests#264
Merged
bear merged 1 commit intobear:python-v3from Dec 6, 2015
jeremylow:python-v3
Merged
Updates Media object with new methods, adds id param, adds tests#264bear merged 1 commit intobear:python-v3from jeremylow:python-v3
bear merged 1 commit intobear:python-v3from
jeremylow:python-v3
Conversation
bear
added a commit
that referenced
this pull request
Dec 6, 2015
Updates Media object with new methods, adds id param, adds tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that, since Python 3 removed the
iteritems()(see line 32) method for dictionaries, constructing a Media object fails.I also updated the Media object to have parity with User and Status objects with:
AsJsonString()__str____ne__methods, since those are present on other objects; Media objects should probably get an ID as well, since this is included with the response from twitter (and might be helpful with chunked media depending on how that gets implemented).
This is my second pull request, so let me know if I'm doing something wrong. New tests are included, since it doesn't look like Media gets tested as it currently stands.