This repository was archived by the owner on Aug 7, 2024. It is now read-only.
Adding api methods for suggestions and suggestions/:slug#254
Merged
bear merged 7 commits intobear:masterfrom Nov 14, 2015
Merged
Adding api methods for suggestions and suggestions/:slug#254bear merged 7 commits intobear:masterfrom
bear merged 7 commits intobear:masterfrom
Conversation
setup.py
Outdated
Author
There was a problem hiding this comment.
This is just my idea for the version jump... not sure if you use this sort of versioning but it maybe sane for such a small jump like this
Owner
|
we do use patch levels, but the 2.3 is already a jump for a larger change -- so no need to bump it IMO |
Author
|
I agree with the version issue, I've swapped this back to 2.3 :) |
…ated api to use these
Author
|
I also required the media data from a tweet. So I've added a commit to add that to a class :). |
Owner
|
I need to fix the travis config to not test on python v3 until the python v3 branch is live... long winded way of saying that i'm going to merge this - thanks for the PR! |
bear
added a commit
that referenced
this pull request
Nov 14, 2015
Adding api methods for suggestions and suggestions/:slug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey!
So I needed these endpoints for a project I'm working on at work so I thought I would add them :)
Follows your normal layout and I added some classes too.
Works like a charm :)
Happy to clean up/Add any more doco so we can merge it back in just let me know.
It's been kind of a rushed job since I needed it to work asap haha.
Thanks for your lib it rocks!!