This repository was archived by the owner on Aug 7, 2024. It is now read-only.
fix tests that weren't already broken on py3#218
Merged
bear merged 1 commit intobear:python-v3from Mar 16, 2015
Merged
Conversation
Owner
|
thanks! |
bear
added a commit
that referenced
this pull request
Mar 16, 2015
fix tests that weren't already broken on py3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's some fixes to get the tests passing on py3 with the exception of the api tests, which seem to have been already broken because they try to call SetUrllib to use a mock urllib which has apparently been removed.
Might have a crack at fixing that up too at some point.
Tested on python 2.7, 3.4.