Conversation
Contributor
opeongo
commented
Jan 8, 2024
opeongo
commented
- All comments are special tokens
- remove BSHFormalComment and add accessor methods to Parser
- add and modify tests
- adjust bshdoc.bsh to use accessor methods
- All comments are special tokens - remove BSHFormalComment and add accessor methods to Parser - add and modify tests - adjust bshdoc.bsh to use accessor methods
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #756 +/- ##
=========================================
Coverage 74.24% 74.24%
+ Complexity 3042 3041 -1
=========================================
Files 108 107 -1
Lines 9357 9354 -3
Branches 1857 1857
=========================================
- Hits 6947 6945 -2
+ Misses 2070 2069 -1
Partials 340 340
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nickl-
requested changes
Mar 21, 2024
| bshdoc( String [] filenames ) | ||
| bshdocl( String [] filenames ) | ||
| { | ||
| System.err.println("filenames="+Arrays.toString(filenames)); |
| return; | ||
| } | ||
| bshdoc( list ); | ||
| System.err.println("list="+Arrays.toString(list)); |
Member
There was a problem hiding this comment.
Same as previous instance of System.err.println
Merged
Member
|
Looks good, just check on the debugging code. |
Member
|
Still waiting on review fixes |
Contributor
Author
|
Updated now for review comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.