Conversation
- patch generated sources to fix upstream bug - add test This patch is temporary until upstream updates to a correct version
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #755 +/- ##
============================================
+ Coverage 74.24% 74.26% +0.02%
- Complexity 3042 3043 +1
============================================
Files 108 108
Lines 9357 9357
Branches 1857 1857
============================================
+ Hits 6947 6949 +2
+ Misses 2070 2069 -1
+ Partials 340 339 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Might as well merge this one, upstream seems to be awol. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR patches the output from javacc to correct a bug that prevented the parsing of long tokens. The fix for the bug was submitted to upstream but has not been packaged up yet. Consider this to be a temporary patch until the fixed version becomes available.