Conversation
…d. Previously it used an imprecise equals method that led to collisions and occasionally returned null values. - Move the namespace swap out of the iterative loop in BSHEnhancedForLoop to avoid unnecessary lookups.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #741 +/- ##
============================================
- Coverage 74.24% 74.19% -0.05%
+ Complexity 3041 3038 -3
============================================
Files 108 108
Lines 9354 9313 -41
Branches 1857 1862 +5
============================================
- Hits 6945 6910 -35
+ Misses 2070 2062 -8
- Partials 339 341 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Use ValueReferenceMap instead of ReferenceCache in BshClassManager Add test
patniemeyer
force-pushed
the
fix_659_again
branch
from
56f5523 to
5a3fb21
Compare
|
Can we have some discussion on this or perhaps get it merged? |
|
Just one anecdotal data point: My application was encountering the same NPE mentioned in this comment. Applying the changes from this branch resolved the issue. Thank you, opeongo, for the time and effort you put into debugging this issue! |
Thanks for the feedback. It is nice to know that someone else is out there. |
|
Will take some time to review this, it seems to be doing more than one thing. |
3 participants
Change the way the way that the block namespace cache is implemented. Previously it used an imprecise equals method that led to collisions and occasionally returned null values.
Move the namespace swap out of the iterative loop in BSHEnhancedForLoop to avoid unnecessary lookups.