Conversation
Codecov Report
@@ Coverage Diff @@
## master #678 +/- ##
============================================
+ Coverage 71.27% 71.31% +0.04%
- Complexity 2791 2796 +5
============================================
Files 106 106
Lines 9087 9121 +34
Branches 1772 1776 +4
============================================
+ Hits 6477 6505 +28
- Misses 2199 2204 +5
- Partials 411 412 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
Fixes beanshell#421 which originally reported the problems with cloning scripted objects. Had to deep copy all the contexts and most references to finally be able to produce two independent instances after a clone. Also completed the existing attempt to implement cloning, and we now return an actual instance instead of just copied This namespace.
nickl-
force-pushed
the
fix_cloneable
branch
from
320f79a to
8b6cbfc
Compare
|
Scrutinizer insists that we should remove the clone I added on bshmethod. There is some poetic justice in the thought that when implementing clone you will at least add one cloneable class. This patch already took way more time then I initially expected, the methods need to copied or they simply produce garbage, and yes clone is a messed up api and we are likely going to see more issues on this in the future. I will probably write a manual copy for methods at some point but right now it seems like too much effort and no reward. The clone is working for now... |
Fix cloneable support.
1 participant
Fixes #421 which originally reported the problems with cloning scripted objects.
Had to deep copy all the contexts and most references to finally be able to produce two independent instances after a clone. Also completed the existing attempt to implement cloning, and we now return an actual instance instead of just copied This namespace.