Closed
Conversation
|
|
Member
|
Thank you for this! For some reason the CI didn't run so no way to test the regression, will try get that going. |
Member
|
There appears to be build errors or tests failing. Please advise... |
Author
|
Seems to be concurrency related error. Not sure what's causing it. I didn't test locally, because some tests fail on my machine. No problem if this cannot be merged. Just thought someone may want to run it on Android in future. |
Member
|
There may be something wrong with the CI scripts not sure why it stopped running automatically or why it is failing all the open PRs. Will need to make time and come through this... |
nickl-
added a commit
to nickl-/beanshell
that referenced
this pull request
Jan 3, 2023
Fixes beanshell#498 NPE in TargetError with null cause. Fixes beanshell#322 /*** ***/ is not a formal comment Fixes beanshell#536 added 5 new operators ??, ??=, ?:, ?., and <=> Fixes beanshell#609 obfuscate bsh.Primitive to expose math methods Fixes beanshell#684 can now cast to type Number from primitive Fixes beanshell#663 identifier defined array dimensions for parameters Fixes beanshell#651 avoid NPE on package access property and use null Support for var keyword tested, appears to work with nothing added. Added Types get primitive type and isNumeric from class Auto narrowing and widening of primitives cast added Detect method signature of widening to BigInteger and BigDecimal as assignable and more specific then Object
nickl-
added a commit
to nickl-/beanshell
that referenced
this pull request
Jan 3, 2023
Fixes beanshell#498 NPE in TargetError with null cause. Fixes beanshell#322 /*** ***/ is not a formal comment Fixes beanshell#536 added 5 new operators ??, ??=, ?:, ?., and <=> Fixes beanshell#609 obfuscate bsh.Primitive to expose math methods Fixes beanshell#684 can now cast to type Number from primitive Fixes beanshell#663 identifier defined array dimensions for parameters Fixes beanshell#651 avoid NPE on package access property and use null Support for var keyword tested, appears to work with nothing added. Added Types get primitive type and isNumeric from class Auto narrowing and widening of primitives cast added Detect method signature of widening to BigInteger and BigDecimal as assignable and more specific then Object
pgiffuni
pushed a commit
to pgiffuni/beanshell
that referenced
this pull request
Jan 8, 2024
Fixes beanshell#498 NPE in TargetError with null cause. Fixes beanshell#322 /*** ***/ is not a formal comment Fixes beanshell#536 added 5 new operators ??, ??=, ?:, ?., and <=> Fixes beanshell#609 obfuscate bsh.Primitive to expose math methods Fixes beanshell#684 can now cast to type Number from primitive Fixes beanshell#663 identifier defined array dimensions for parameters Fixes beanshell#651 avoid NPE on package access property and use null Support for var keyword tested, appears to work with nothing added. Added Types get primitive type and isNumeric from class Auto narrowing and widening of primitives cast added Detect method signature of widening to BigInteger and BigDecimal as assignable and more specific then Object
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a small NPE on Android, which happens because Security.getProperty call returns null there.