Skip to content

Fix Maven Central link in readme#640

Open
charlie-cadmv wants to merge 880 commits intobeanshell:masterfrom
charlie-cadmv:patch-1
Open

Fix Maven Central link in readme#640
charlie-cadmv wants to merge 880 commits intobeanshell:masterfrom
charlie-cadmv:patch-1

Conversation

@charlie-cadmv
Copy link
Contributor

HTTP access to maven.org was disabled in early 2020, and at the same time they retired several domain names including central.maven.org.
https://central.sonatype.org/changelog/#2020-01-15-legacy-and-unsecure-http-accesses-disabled

nickl- and others added 30 commits March 19, 2019 20:34
as per stefanofornari/BshConsole#2
EOF parser exception can only occur in interactive mode when interpreter is interrupted (Ctrl+C) during multi line input, since this was a user decision there is no point complaining about it.
Since we are minimum JDK 1.8 and with modern javacc these legacy work arounds are not required anymore.
Target errors nested were not properly unwrapped.
Removed the need for referencing both target and thrown and other small clean ups.
Fixed 1 test asserting for \n but translated to windows \r this is now trimmed before compare
Mark 1 test as known issue unicode comparison failed
Can now successfully compile and run
Tested on Windows 10 with both JDK 1.8 and Java 10
Ensure that we are comparing apples with apples.
Tests for BshClassPath coverage and to ensure rt.jar or equivalent gets loaded.
In byte code when building the args array instead of having to loop the args again in This.invokeMethod.
Logically order the primitives.
Made Interpreter.DEBUG ThreadLocal to play nice with others.
Improved Interpreter.debug prompt method to use varargs and StringBuilder.
Normalised usage and removed redundant if (DEBUG) checks when calling debug prompt.
Made accessibility a singleton for assigning an initial value via consumer supplier functions.
setAccessible will now be thread safe.
Caching the prompt is not useful when we are externally expecting the to be called.
Don't close System.out or System.err.
Make EOF an instance variable, set true on close and allow thread yield, using Thread.sleep, on parser exception to wait for closing.
Make console null and avoid null pointer exception if printing after close.
On eval enclosing interpreter might share local reader, avoid auto close.
From millisecond time to nanoseconds as the former only reported 0.
Moved getClassStaticThis and getClassInstanceThis from This to Reflect.
Before all classes were treated as non static inner classes and local classes didn't get local variable scope.
Now static inner classes only have static scope, inner classes and local classes have static and instance scope of outer class and local classes have method scope.
use string split instead of string manipulation (indexOf, substring).
lazy build compounds as needed.
weak reference cache name compounds build only once.
completed unit tests.
  * Fix equality at Primitive.equals as well as operators
  * Fixes to castNumber
    ** removed redundant checkonly which cannot exist with fromvalue and we need the value for castNumber.
    ** return the number instead of Primitive, rather wrap on demand than having to unwrap needlessly
    ** removed BigDecimal reference requirement and parse string number operations
    ** optimise constant zero and one assessment
  * abandon shrink to float minimum, turns out the loss in precision is significant. back to default floating point data type double... as per java. see beanshell#71
  * cleanup and fixes to BSH nodes BinaryExpression, UnaryExpression, Assignment (operators implementation) and Literal.
  * refactor, relocate methods Type lookups isNumeric, isFloatingPoint, isPrimitive
  * additional primitive unit tests including floating point precision analysis
This allows a better integration with console libraruies which usually
manage the prompt on their own. It seems to be a functionality closer
to the responsibility of the console rather than the interpreter.
Instead of using the namespace.
opeongo and others added 26 commits January 12, 2022 15:03
Fix problem with sourceFileInfo being in URL format and breaking the …
Better handling of VarArgs methods and constructors.
Add codecov workflow action to upload reports
@nickl-
Copy link
Member

nickl- commented Dec 6, 2022

Actually we are using the org.beanshell vendor id.

@charlie-cadmv
Copy link
Contributor Author

charlie-cadmv commented Dec 6, 2022

The example refers to 2.06b, and that version is available through org.apache-extras but not through org.beanshell so there's no simple fix.

Also, the JCenter link uses the same org.apache-extras classpath.

Is it possible to push 2.06b to Maven under org.beanshell?

@nickl-
Copy link
Member

nickl- commented Dec 6, 2022

The example refers to 2.06b, and that version is available through org.apache-extras but not through org.beanshell so there's no simple fix.

Ahh yes of course, we could change that to the SNAPSHOT release or hmmmm rater wait for the official release.

There is also the 2.1.1 release as a contender.

Also, the JCenter link uses the same org.apache-extras classpath.

Yes I can imagine, we're also using sonatype now not bintray anymore.

Is it possible to push 2.06b to Maven under org.beanshell?

Only if we can still build it, staging releases is quite involved. What I nice mess we have. =)

Lets iron this out in the new year, hoping to have more progress by then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.