Better handling of VarArgs methods and constructors.#621
Merged
opeongo merged 4 commits intobeanshell:masterfrom Jan 13, 2022
Merged
Better handling of VarArgs methods and constructors.#621opeongo merged 4 commits intobeanshell:masterfrom
opeongo merged 4 commits intobeanshell:masterfrom
Conversation
Fix for issue beanshell#620. Closer following of JLS 15.12.2 method resolution rules. Propagate VarArgs flag to generated methods. Better marshalling of arguments in vararga methods.
Fix problem marshalling fixed arity parameters
Member
|
Looks good...RTBC |
pgiffuni
pushed a commit
to pgiffuni/beanshell
that referenced
this pull request
Jan 8, 2024
Better handling of VarArgs methods and constructors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #620.
Closer following of JLS 15.12.2 method resolution rules.
Propagate VarArgs flag to generated methods.
Better marshalling of arguments in varargs methods.
Update test cases.
This touched a few more files than I expected but it turned out that there were a few more loose ends.