Fix the JSR223 script engine#608
Merged
opeongo merged 3 commits intobeanshell:masterfrom Jan 12, 2022
Merged
Conversation
…cope that they are found in. The previous version would always set variables in the ENGINE_SCOPE, thus causing global scope variables to be shadowed. Add tests for correctness.
nickl-
reviewed
Jan 19, 2022
| int scope = context.getAttributesScope(key); | ||
| if (scope<0) | ||
| scope = ENGINE_SCOPE; | ||
| Object oldValue = context.getAttribute(key); |
Member
There was a problem hiding this comment.
Shouldn't this still have the scope, we know now where to look for it?
Object oldValue = context.getAttribute(key, scope);
pgiffuni
pushed a commit
to pgiffuni/beanshell
that referenced
this pull request
Jan 8, 2024
Fix the JSR223 script engine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the JSR223 script engine plugin so update variables in the same scope that they are found in. The previous version would always set variables in the ENGINE_SCOPE, thus causing global scope variables to be shadowed.
Add tests for correctness.
This PR provides a fix for issue #607.