Collapse reviewer notes by default

bd808 · bd808 · commit e2bc47e454f3 · 2014-10-01T15:18:01.000-06:00
diff --git a/data/i18n/en.json b/data/i18n/en.json
@@ -177,5 +177,7 @@
 	"report-aggregated-ability": "Ability",
 	"report-aggregated-engagement": "Engagement",
 	"report-aggregated-recommend": "Recommend",
-	"report-format-recommend": "$3% ($1/$2)"
+	"report-format-recommend": "$3% ($1/$2)",
+
+	"reviews-notes": "Reviewer notes"
 }
diff --git a/data/i18n/qqq.json b/data/i18n/qqq.json
@@ -131,5 +131,7 @@
 	"proposals-list-theme": "Table column header",
 	"proposals-list-amount": "Table column header",
 	"proposals-list-reviews": "Table column header",
-	"proposals-list-myreviews": "Table column header"
+	"proposals-list-myreviews": "Table column header",
+
+	"reviews-notes": "Section header"
 }
diff --git a/data/templates/proposals/view_reviews.html b/data/templates/proposals/view_reviews.html
@@ -5,7 +5,7 @@
 {% set note = crit ~ '_note' %}
 <section class="panel panel-default">
   <div class="panel-heading">
-    <h3 class="panel-title">{{ ( 'review-' ~ crit )|message }}
+    <h3 class="panel-title">{{ ( 'review-' ~ crit )|message }}</h3>
   </div>
   <table class="table table-bordered table-hover table-condensed">
     <thead>
@@ -20,18 +20,27 @@ <h3 class="panel-title">{{ ( 'review-' ~ crit )|message }}
       {{ helpers.stats( reviews, crit ) }}
     </tbody>
   </table>
-  <ul class="list-group">
-  {% for review in reviews %}
-    {% if review[note] %}
-    <li class="list-group-item clearfix">
-      {{ review[note]|markdown }}
-      {% if ctx.isadmin|default( false ) %}
-      <cite class="pull-right text-muted">&mdash; {{ review.reviewer_name }}</cite>
-      {% endif %}
-    </li>
-    {% endif %}
-  {% endfor %}
-  </ul>
+  <section class="panel panel-default muted">
+    <div class="panel-heading">
+      <a class="accordion-toggle collapsed" data-toggle="collapse" href="#{{ crit }}-notes">
+        <span class="text-muted">{{ 'reviews-notes'|message }}</span>
+      </a>
+    </div>
+    <div id="{{ crit }}-notes" class="panel-body panel-collapse collapse">
+      <ul class="list-group">
+      {% for review in reviews %}
+        {% if review[note] %}
+        <li class="list-group-item clearfix">
+          {{ review[note]|markdown }}
+          {% if ctx.isadmin|default( false ) %}
+          <cite class="pull-right text-muted">&mdash; {{ review.reviewer_name }}</cite>
+          {% endif %}
+        </li>
+        {% endif %}
+      {% endfor %}
+      </ul>
+    </div>
+  </section>
 </section>
 {% endmacro %}
 
@@ -112,18 +121,27 @@ <h3 class="panel-title">{{ 'review-recommendation'|message }}
             </tr>
           </tbody>
         </table>
-        <ul class="list-group">
-        {% for review in reviews %}
-          {% if review.comments %}
-          <li class="list-group-item clearfix">
-            {{ review.comments|markdown }}
-            {% if isadmin|default( false ) %}
-            <cite class="pull-right text-muted">&mdash; {{ review.reviewer_name }}</cite>
-            {% endif %}
-          </li>
-          {% endif %}
-        {% endfor %}
-        </ul>
+        <section class="panel panel-default muted">
+          <div class="panel-heading">
+            <a class="accordion-toggle collapsed" data-toggle="collapse" href="#recommendation-notes">
+              <span class="text-muted">{{ 'reviews-notes'|message }}</span>
+            </a>
+          </div>
+          <div id="recommendation-notes" class="panel-body panel-collapse collapse">
+            <ul class="list-group">
+            {% for review in reviews %}
+              {% if review.comments %}
+              <li class="list-group-item clearfix">
+                {{ review.comments|markdown }}
+                {% if isadmin|default( false ) %}
+                <cite class="pull-right text-muted">&mdash; {{ review.reviewer_name }}</cite>
+                {% endif %}
+              </li>
+              {% endif %}
+            {% endfor %}
+            </ul>
+          </div>
+        </section>
       </section>
     </div>
   </section>
diff --git a/public/css/main.css b/public/css/main.css
@@ -88,6 +88,19 @@ a:visited {
   color:grey;
 }
 
+.panel-group table.table-bordered + .panel {
+  border-top-left-radius:0;
+  border-top-right-radius:0;
+}
+
+.panel-default.muted > .panel-heading {
+  background-color:transparent;
+}
+
+a.accordion-toggle {
+  text-decoration:none;
+}
+
 a.sortable {
   display:block;
   padding-right:18px;

Original file line number	Diff line number	Diff line change
`@@ -177,5 +177,7 @@`
`177`	`177`	`"report-aggregated-ability": "Ability",`
`178`	`178`	`"report-aggregated-engagement": "Engagement",`
`179`	`179`	`"report-aggregated-recommend": "Recommend",`
`180`		`- "report-format-recommend": "$3% ($1/$2)"`
	`180`	`+ "report-format-recommend": "$3% ($1/$2)",`
	`181`	`+`
	`182`	`+ "reviews-notes": "Reviewer notes"`
`181`	`183`	`}`
Original file line number	Diff line number	Diff line change
`@@ -131,5 +131,7 @@`
`131`	`131`	`"proposals-list-theme": "Table column header",`
`132`	`132`	`"proposals-list-amount": "Table column header",`
`133`	`133`	`"proposals-list-reviews": "Table column header",`
`134`		`- "proposals-list-myreviews": "Table column header"`
	`134`	`+ "proposals-list-myreviews": "Table column header",`
	`135`	`+`
	`136`	`+ "reviews-notes": "Section header"`
`135`	`137`	`}`