Skip to content

Docs: improve PHPDoc return annotations#39

Closed
manhphuc wants to merge 1 commit intobbpress:trunkfrom
manhphuc:docs/fix-missing-return-docblocks
Closed

Docs: improve PHPDoc return annotations#39
manhphuc wants to merge 1 commit intobbpress:trunkfrom
manhphuc:docs/fix-missing-return-docblocks

Conversation

@manhphuc
Copy link
Copy Markdown

Adds missing @return void annotations to two docblocks.

No functional changes.

@manhphuc manhphuc changed the title Docs: add missing @return void tags Docs: improve PHPDoc return annotations Dec 28, 2025
@JJJ
Copy link
Copy Markdown
Contributor

JJJ commented Dec 29, 2025

Fixed here: https://bbpress.trac.wordpress.org/changeset/7392

Thanks!

@JJJ JJJ closed this Dec 29, 2025
emaralive pushed a commit to emaralive/test-bbpress-mirror that referenced this pull request Dec 29, 2025
…tags.

Props manhphuc.

See: bbpress/bbPress#39

In trunk, for 2.7.

git-svn-id: https://bbpress.svn.wordpress.org/trunk@7392 9866e705-20ec-0310-96e7-cbb4277adcfb
@manhphuc
Copy link
Copy Markdown
Author

manhphuc commented Jan 8, 2026

Hi! Just a quick note regarding the props 🙂

It looks like the credit was assigned to:
https://profiles.wordpress.org/manhphuc/

My correct WordPress.org username is:
https://profiles.wordpress.org/manhphucofficial/

Could this be updated when you have a moment?
Thanks again for the review and merge!

@JJJ
Copy link
Copy Markdown
Contributor

JJJ commented Jan 12, 2026

Sorry about that. 🙈

Unfortunately I'm not able to retroactively modify the existing commit message & props, but I did manually grant you the "bbPress Contributor" badge on your WordPress.org Profile. 🐝

@manhphuc
Copy link
Copy Markdown
Author

Thanks for checking and for granting the badge — really appreciate it!

Totally understand the limitation around retroactive changes.
Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants