Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a module info to the final build under
META-INF/versions/9. This should not affect compatibility with java 8.I'm working my way through the dependency tree of https://github.com/bbottema/simple-java-mail.
For reference, I am producing these lists of exports/requires by upping the java version locally and then adding a module-info and following the compiler errors. While on Java 8 its sorta like guessing at what imports are needed at the top of a file without a compiler/IDE support.
For single modules like this its tenable, but if you are okay with upgrading past 8 at some point that would be helpful.