added index.d.ts #66
Merged
added index.d.ts #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typescript support
WaveformData => WaveformDataType
chrisn
requested changes
Feb 20, 2020
Member
chrisn
left a comment
chrisn
left a comment
There was a problem hiding this comment.
Thank you for contributing! Typescript declarations are a great addition. I left a few minor comments, please take a look.
length, bits, duration, pixels_per_second, channels, sample_rate, scale are set as readonly min_array and max_array do not take parameters 'concat' method declaration updated 'create' static method declaration updated added AudioWaveform type declaration added 'createFromAudio' static method (+ corresponding types)
Contributor
Author
|
Thank you for your comments! |
AudioWaveForm => AudioWaveform
chrisn
reviewed
Feb 21, 2020
rename: AudioWaveform => JsonWaveformData (to keep the name consistent with peeks.js)
Member
|
Thanks! I'll merge this and do some tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typescript support