Rename java/modules to java/common#174
Closed
fmeum wants to merge 1 commit into
Closed
Conversation
Contributor
Author
Contributor
Author
|
We discussed this on the ruleset structure design doc, where |
The term "modules" is easily confused with "Bazel modules" from Bzlmod.
hvadehra
approved these changes
Mar 11, 2024
comius
pushed a commit
to comius/rules_java
that referenced
this pull request
Sep 2, 2024
Copybara Import from bazelbuild#174 BEGIN_PUBLIC Rename `java/modules` to `java/common` (bazelbuild#174) The term "modules" is easily confused with "Bazel modules" from Bzlmod. Closes bazelbuild#174 END_PUBLIC COPYBARA_INTEGRATE_REVIEW=bazelbuild#174 from fmeum:master 5a9babe PiperOrigin-RevId: 615070661 Change-Id: I0731edb4f8ce3e6a19a742fe7fd51dbde05bd53b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The term "modules" is easily confused with "Bazel modules" from Bzlmod.