sorted imports statements and apply "black" formatting - #583
Merged
Conversation
UebelAndre
marked this pull request as ready for review
December 28, 2021 02:01
UebelAndre
requested review from
andyscott,
brandjon,
lberki and
thundergolfer
as code owners
December 28, 2021 02:01
Contributor
|
Please use the Then |
UebelAndre
changed the title
Contributor
|
Nice, thanks. Now we're just missing pre-commit.ci to yell at contributors who didn't install the pre-commit hook. |
alexeagle
approved these changes
Dec 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
.parfiles. See CONTRIBUTING.md for infoPR Type
What kind of change does this PR introduce?
This PR is a minor cleanup I've pulled out of another set of changes I'm working on. I noticed in quite a few files that there were some unused import warnings poping up around the code base so I'd fixed those and ran isort to get some "import-exclusive" formatting to reduce as much noise in git history as possible.
What is the current behavior?
Import statements are unsorted and include unused imports.
Issue Number: N/A
What is the new behavior?
Imports are sorted to try and promote good code hygiene.
Does this PR introduce a breaking change?
Other information