Skip to content

Feat apply ruff#497

Merged
till-m merged 69 commits intobayesian-optimization:masterfrom
phi-friday:feat-apply-ruff
Jul 23, 2024
Merged

Feat apply ruff#497
till-m merged 69 commits intobayesian-optimization:masterfrom
phi-friday:feat-apply-ruff

Conversation

@phi-friday
Copy link
Contributor

@phi-friday phi-friday commented Jul 11, 2024

apply ruff example
related: #496

@phi-friday phi-friday marked this pull request as ready for review July 11, 2024 09:18
@codecov
Copy link

codecov bot commented Jul 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 89.89899% with 20 lines in your changes missing coverage. Please review.

Project coverage is 95.93%. Comparing base (abdd535) to head (b97646d).
Report is 2 commits behind head on master.

Files Patch % Lines
bayes_opt/logger.py 69.23% 8 Missing ⚠️
bayes_opt/acquisition.py 92.45% 4 Missing ⚠️
bayes_opt/target_space.py 87.87% 4 Missing ⚠️
bayes_opt/domain_reduction.py 92.00% 2 Missing ⚠️
bayes_opt/util.py 60.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #497      +/-   ##
==========================================
+ Coverage   94.70%   95.93%   +1.22%     
==========================================
  Files           9       10       +1     
  Lines         680      861     +181     
==========================================
+ Hits          644      826     +182     
+ Misses         36       35       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

till-m
till-m reviewed Jul 13, 2024
View reviewed changes
Copy link
Member

@till-m till-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @phi-friday,

thanks for this PR! I think it would really improve this codebase. I would merge #498 before merging this, but I think reviews here might still take some time.
I've commented on some things that I noticed. These are not necessarily requests to change things, it assume there's generally a solid reason for you handling things the way you do that I might not have seen.

Consider this sort of a preliminary review, I would like to have a look again once you feel the PR is ready.

Finally, if there are no objections from you or any other contributors, I might ask a coworker with some more SE experience to additionally review this PR. I don't think my background here is sufficient to provide solid feedback.

@till-m
Copy link
Member

till-m commented Jul 15, 2024

Could you ping me when you feel this is ready for a review?

@phi-friday
Copy link
Contributor Author

phi-friday commented Jul 15, 2024

Could you ping me when you feel this is ready for a review?

@till-m
Until the new ruff version is released, there's nothing else I'd like to modify.
I'm ready.

phi-friday added 24 commits July 17, 2024 20:44
till-m
till-m reviewed Jul 17, 2024
View reviewed changes
Copy link
Member

@till-m till-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, generally. I added some comments to clarify things.

@till-m
Copy link
Member

till-m commented Jul 17, 2024

@Panaetius Ralf, I would appreciate your feedback on this PR, if you have the time. No need to focus too much on the code (which should be functionally the same), the high-level things are what's important.

till-m
till-m approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@till-m till-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the codecov bot is not working correctly and coverage is not being updated?

In any case, I think this PR looks good, insofar as I am able to judge it.

I would wait a bit more to see if anyone else wants to give a review, but then I would merge this soon.

@phi-friday phi-friday mentioned this pull request Jul 19, 2024
Closed
@till-m till-m merged commit 16c00f3 into bayesian-optimization:master Jul 23, 2024
@till-m
Copy link
Member

till-m commented Jul 23, 2024

Thanks for your contribution!

@phi-friday phi-friday deleted the feat-apply-ruff branch July 23, 2024 10:04
@phi-friday phi-friday mentioned this pull request Jul 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@till-m till-m till-m approved these changes

+1 more reviewer

@Panaetius Panaetius Panaetius left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@phi-friday @till-m @Panaetius