Update Inventory Level Resource - #43
Open
imRohan wants to merge 1 commit into
Open
Conversation
imRohan
force-pushed
the
rl-update-fake-il
branch
from
August 7, 2026 14:51
e63740f to
732dc95
Compare
jmazur
approved these changes
Aug 10, 2026
jmazur
reviewed
Aug 10, 2026
| end | ||
| end | ||
| end | ||
| end |
Collaborator
There was a problem hiding this comment.
question about this, i added a comment on the gobble Pr that uses this. why make a serializer class vs adding the to_json method in the original model? This serializer isn't adding much else in terms of functionality. it isnt acting like a regular rails serializer, only to_json
chriswoodford
approved these changes
Aug 13, 2026
chriswoodford
left a comment
chriswoodford
left a comment
Contributor
There was a problem hiding this comment.
re-read the PR description and just clean it up a bit
The inventory level structure has changed, and the API will now be returning a simplified, flatter response structure. Due to this, the InventoryLevel object needs to be refactored to take into account the new response structure and the new top-level key. This change addresses the need by: * Updating the Inventory Level response fake * Updating Inventory Level to account for the new key name
imRohan
force-pushed
the
rl-update-fake-il
branch
from
August 14, 2026 13:17
de77580 to
432a578
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Inventory Level resource was returning an object which was not optimized for readability. Clients would have been required to adjust the object in order to consume the inventory level iteratively. This PR hopes to improve the readability of the Inventory Level object, and includes a serializer which was previously missing while removing a previously unused fake object,
DistributionCenterInventoryThis change addresses the need by: