Fixes for handing of popcnt and for compilation on non-x86 architectures #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if also TB_NO_HW_POP_COUNT is not defined, use a x86 hardware instruction, but only if on a recognized compiler/architecture that has one. Fixes issue #9 (ARM compatibility).
Contributor
Author
|
Is there a reason not to merge this? I think without this pull request the code is not really portable to non-x86 architectures. But I am open to other ways of fixing that. |
1. Check return value from fstat. 2. Use strncpy not strcpy in constructing file path.
Write error messages to stderr, not stdout. Add error checking for unmap function.
Owner
|
Sorry about that. The change did require me to check some things, which I never got around to. There is a backlog of changes needed for Fathom that I currently have little time for. |
…for ARM target). Update copyright and license info.
under C++ 11. Add some asserts.
__cplusplus value to select becauase that is unreliable for MSVC.
overridding the config file by including it from another directory.
it was not being defined. Use std::mutex if C++11 compile. Update copyright.
…ed by Andrew Grant).
move_to_str. Note: this still does not output complete SAN, because no indication of check or mate.
code assumed gcc on x86_64. Now we use builtins if possible and otherwise a De Bruijn multiplication implementation.
1. Expose new interfaces for DTZ and WDL probing with ranks/scores as in Cfish, as well as the old Fathom interface. 2. Put both tbprobe.c and tbchess.c under MIT license. 3. Require atomic support, remove this option from tbconfig.h. 4. Use stdendian for big/little endian support. 5. Add constants for mate scores, pawn scores etc. to tbconfig.h. Note: two test cases from Arasan unit tests still not passing due to Cfish bug.
Also use FILE_FLAG_RANDOM_ACCESS for opening Windows files, as in Stockfish.
…se the constructor
Add top level Makefile for compiling a shared object
Fix install bug if $(DESTDIR)$(INCDIR) does not exist
Fixes issue from PR#10.
Fix race condition caused by init_table failure
NULL. tb_free DID free that memory but did not set the variable to NULL hence confusing the init part.
Fix typo in `tbprobe.h`
Re-iniitalize pawnEntry and pieceEntry variables to NULL after free, to ensure initialization check in tb_init will detect state as uninitialized if called again.
Fix c++20 issue when allocation/deallocating pawnEntry and pieceEntry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always use TB_CUSTOM_POP_COUNT if defined. If not defined and
if also TB_NO_HW_POP_COUNT is not defined, use a x86 hardware
instruction, but only if on a recognized compiler/architecture
that has one. Fixes issue #9 (ARM compatibility).