@@ -19,7 +19,7 @@ def __init__(self, eventQueue = None):
1919 Create a C++ event queue and handler
2020 """
2121 # Make a notify category for this class (unless there already is one)
22- if ( EventManager .notify == None ) :
22+ if EventManager .notify is None :
2323 EventManager .notify = directNotify .newCategory ("EventManager" )
2424
2525 self .eventQueue = eventQueue
@@ -37,8 +37,10 @@ def doEvents(self):
3737 processFunc = self .processEventPstats
3838 else :
3939 processFunc = self .processEvent
40- while (not self .eventQueue .isQueueEmpty ()):
41- processFunc (self .eventQueue .dequeueEvent ())
40+ isEmptyFunc = self .eventQueue .isQueueEmpty
41+ dequeueFunc = self .eventQueue .dequeueEvent
42+ while not isEmptyFunc ():
43+ processFunc (dequeueFunc ())
4244
4345 def eventLoopTask (self , task ):
4446 """
@@ -78,13 +80,13 @@ def processEvent(self, event):
7880 # ******** Duplicate any changes in processEventPstats *********
7981 # **************************************************************
8082 # Get the event name
81- eventName = event .getName ()
83+ eventName = event .name
8284 if eventName :
8385 paramList = []
84- for i in range (event .getNumParameters ()):
85- eventParameter = event .getParameter (i )
86+ for eventParameter in event .parameters :
8687 eventParameterData = self .parseEventParameter (eventParameter )
8788 paramList .append (eventParameterData )
89+
8890 # Do not print the new frame debug, it is too noisy!
8991 if (EventManager .notify .getDebug () and eventName != 'NewFrame' ):
9092 EventManager .notify .debug ('received C++ event named: ' + eventName +
@@ -94,13 +96,12 @@ def processEvent(self, event):
9496 # **************************************************************
9597 # Send the event, we used to send it with the event
9698 # name as a parameter, but now you can use extraArgs for that
97- if paramList :
98- messenger .send (eventName , paramList )
99- else :
100- messenger .send (eventName )
99+ messenger .send (eventName , paramList )
100+
101101 # Also send the event down into C++ land
102- if self .eventHandler :
103- self .eventHandler .dispatchEvent (event )
102+ handler = self .eventHandler
103+ if handler :
104+ handler .dispatchEvent (event )
104105
105106 else :
106107 # An unnamed event from C++ is probably a bad thing
@@ -115,13 +116,13 @@ def processEventPstats(self, event):
115116 # ******** Duplicate any changes in processEvent *********
116117 # ********************************************************
117118 # Get the event name
118- eventName = event .getName ()
119+ eventName = event .name
119120 if eventName :
120121 paramList = []
121- for i in range (event .getNumParameters ()):
122- eventParameter = event .getParameter (i )
122+ for eventParameter in event .parameters :
123123 eventParameterData = self .parseEventParameter (eventParameter )
124124 paramList .append (eventParameterData )
125+
125126 # Do not print the new frame debug, it is too noisy!
126127 if (EventManager .notify .getDebug () and eventName != 'NewFrame' ):
127128 EventManager .notify .debug ('received C++ event named: ' + eventName +
@@ -131,45 +132,36 @@ def processEventPstats(self, event):
131132 # ********************************************************
132133 # ******** Duplicate any changes in processEvent *********
133134 # ********************************************************
134- if self ._wantPstats :
135- name = eventName
136- hyphen = name .find ('-' )
137- if hyphen >= 0 :
138- name = name [0 :hyphen ]
139- pstatCollector = PStatCollector ('App:Show code:eventManager:' + name )
140- pstatCollector .start ()
141- if self .eventHandler :
142- cppPstatCollector = PStatCollector (
143- 'App:Show code:eventManager:' + name + ':C++' )
144-
145- if paramList :
146- messenger .send (eventName , paramList )
147- else :
148- messenger .send (eventName )
149- # Also send the event down into C++ land
135+ name = eventName
136+ hyphen = name .find ('-' )
137+ if hyphen >= 0 :
138+ name = name [0 :hyphen ]
139+ pstatCollector = PStatCollector ('App:Show code:eventManager:' + name )
140+ pstatCollector .start ()
150141 if self .eventHandler :
151- if self ._wantPstats :
152- cppPstatCollector .start ()
153- self .eventHandler .dispatchEvent (event )
154- # ********************************************************
155- # ******** Duplicate any changes in processEvent *********
156- # ********************************************************
142+ cppPstatCollector = PStatCollector (
143+ 'App:Show code:eventManager:' + name + ':C++' )
157144
158- if self ._wantPstats :
159- if self .eventHandler :
160- cppPstatCollector .stop ()
161- pstatCollector .stop ()
145+ messenger .send (eventName , paramList )
146+
147+ # Also send the event down into C++ land
148+ handler = self .eventHandler
149+ if handler :
150+ cppPstatCollector .start ()
151+ handler .dispatchEvent (event )
152+ cppPstatCollector .stop ()
153+
154+ pstatCollector .stop ()
162155
163156 else :
164157 # An unnamed event from C++ is probably a bad thing
165158 EventManager .notify .warning ('unnamed event in processEvent' )
166159
167-
168160 def restart (self ):
169- if self .eventQueue == None :
161+ if self .eventQueue is None :
170162 self .eventQueue = EventQueue .getGlobalEventQueue ()
171163
172- if self .eventHandler == None :
164+ if self .eventHandler is None :
173165 if self .eventQueue == EventQueue .getGlobalEventQueue ():
174166 # If we are using the global event queue, then we also
175167 # want to use the global event handler.
0 commit comments