Implement exceptions for listing operations. #518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmoore
approved these changes
Feb 1, 2017
Contributor
alexmoore
left a comment
alexmoore
left a comment
There was a problem hiding this comment.
+1.
🥇 for using our standard warning text 😄
alexmoore
suggested changes
Feb 8, 2017
Contributor
alexmoore
left a comment
alexmoore
left a comment
There was a problem hiding this comment.
We'll need to check bucket-ish inputs for the MapReduce builders/objects like we do with Ruby too.
alexmoore
suggested changes
Feb 8, 2017
Contributor
alexmoore
left a comment
alexmoore
left a comment
There was a problem hiding this comment.
Also need a check on TS stream_keys.
Contributor
Author
|
Yeah I didn't look too much into that because I didn't know if it was worth the effort to distinguish different inputs. I'll check it out further. |
Contributor
Author
alexmoore
approved these changes
Feb 9, 2017
Contributor
alexmoore
left a comment
alexmoore
left a comment
There was a problem hiding this comment.
I found a whitespace blemish, but I'll let it slide... 👍
| :type timeout: int | ||
| :rtype: iterator | ||
| """ | ||
| if not riak.disable_list_exceptions: |
Contributor
There was a problem hiding this comment.
Ahh, I missed this the first time, I thought it'd be in another file.
lukebakken
force-pushed
the
features/lrb/gh-517_CLIENTS-1070
branch
from
bdc58bf to
488c22b
Compare
added 2 commits
February 9, 2017 08:39
…own during expensive operations. Raise ListError if mapreduce over a bucket is attempted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #517 (CLIENTS-1070) (CLIENTS-1070) (CLIENTS-1070) and CLIENTS-1070